Skip to content

Fix LookDev env library assignment after leaving playmode. #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Fix LookDev env library assignment after leaving playmode. #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab850c6
Fixed LookDev environment library assignement after leaving playmode.
JulienIgnace-Unity Jan 21, 2021
a8f3365
Update changelog
JulienIgnace-Unity Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion com.unity.render-pipelines.core/Editor/LookDev/LookDev.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ static void LinkViewDisplayer()

static void LinkEnvironmentDisplayer()
{
s_EnvironmentDisplayer.OnChangingEnvironmentLibrary += currentContext.UpdateEnvironmentLibrary;
s_EnvironmentDisplayer.OnChangingEnvironmentLibrary += UpdateEnvironmentLibrary;
}

static void UpdateEnvironmentLibrary(EnvironmentLibrary library)
{
LookDev.currentContext.UpdateEnvironmentLibrary(library);
}

static void ReloadStage(bool reloadWithTemporaryID)
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed shadow matte not working with ambient occlusion when MSAA is enabled
- Fixed exception when changing the current render pipeline to from HDRP to universal (case 1306291).
- Fixed an issue in shadergraph when switch from a RenderingPass (case 1307653)
- Fixed LookDev environment library assignement after leaving playmode.

### Changed
- Change the source value for the ray tracing frame index iterator from m_FrameCount to the camera frame count (case 1301356).
Expand Down