Skip to content

Fix bad merge of the light loop optimization PR (an optimization was undone) #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2712,7 +2712,8 @@ bool PrepareLightsForGPU(CommandBuffer cmd, HDCamera hdCamera, CullingResults cu
internal void ReserveCookieAtlasTexture(HDAdditionalLightData hdLightData, Light light, HDLightType lightType)
{
// Note: light component can be null if a Light is used for shuriken particle lighting.
switch (hdLightData.ComputeLightType(light))
lightType = light == null ? HDLightType.Point : lightType;
switch (lightType)
{
case HDLightType.Directional:
m_TextureCaches.lightCookieManager.ReserveSpace(hdLightData.surfaceTexture);
Expand Down