Skip to content

[HDRP] Fix error in the RTHandle scale of Depth Of Field when TAA is enabled #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue in shadergraph when switch from a RenderingPass (case 1307653)
- Fixed LookDev environment library assignement after leaving playmode.
- Fixed a locale issue with the diffusion profile property values in ShaderGraph on PC where comma is the decimal separator.
- Fixed error in the RTHandle scale of Depth Of Field when TAA is enabled.

### Changed
- Change the source value for the ray tracing frame index iterator from m_FrameCount to the camera frame count (case 1301356).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1571,9 +1571,9 @@ static void DoDepthOfField(in DepthOfFieldParameters dofParameters, CommandBuffe
float nearMaxBlur = dofParameters.nearMaxBlur * resolutionScale;

// If TAA is enabled we use the camera history system to grab CoC history textures, but
// because these don't use the same RTHandle system as the global one we'll have a
// different scale than _RTHandleScale so we need to handle our own
var cocHistoryScale = RTHandles.rtHandleProperties.rtHandleScale;
// because these don't use the same RTHandleScale as the global one, we need to use
// the RTHandleScale of the history RTHandles
var cocHistoryScale = taaEnabled ? dofParameters.camera.historyRTHandleProperties.rtHandleScale : RTHandles.rtHandleProperties.rtHandleScale;

ComputeShader cs;
int kernel;
Expand Down