Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VFX test projects to use MockHMD when running XR tests #3140

Merged
merged 10 commits into from
Jan 19, 2021
Merged

Update VFX test projects to use MockHMD when running XR tests #3140

merged 10 commits into from
Jan 19, 2021

Conversation

fabien-unity
Copy link
Collaborator

@fabien-unity fabien-unity commented Jan 15, 2021 •
edited
Loading

Purpose of this PR

  • unlock the ability to run VFX automated tests with XR and MockHMD
  • disable async shader compilation on VFX test projects to fix instabilities
  • use WaitForEndOfFrame to fix some timing issues (009_MultiCamera)

Testing status

  • Tested locally with URP/HDRP in standard and XR modes
  • Tested on Yamato with nightly triggers
  1. Nightly VFX_HDRP - trunk : https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/tests%252Fxr%252Fconvert-to-mockhmd-vfx/.yamato%252Fall-vfx_hdrp.yml%2523Nightly_VFX_HDRP_trunk/4935817/job/pipeline
  2. Nightly VFX_URP - trunk : https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/tests%252Fxr%252Fconvert-to-mockhmd-vfx/.yamato%252Fall-vfx_urp.yml%2523Nightly_VFX_URP_trunk/4935768/job/pipeline

Comments to reviewers

  • this PR contains updates to some reference images
  • test 23 in HDRP is now disabled in XR because of the UI showing up only in XR (needs more investigation later), I used 2021.1.0b2 to save the scene

@fabien-unity fabien-unity marked this pull request as ready for review January 19, 2021 15:16
@sebastienlagarde sebastienlagarde merged commit d5dd712 into master Jan 19, 2021
@sebastienlagarde sebastienlagarde deleted the tests/xr/convert-to-mockhmd-vfx branch January 19, 2021 20:41
@PaulDemeulenaere
Copy link
Contributor

Updating NDA image reference at : https://github.cds.internal.unity3d.com/unity/ScriptableRenderPipelinePrivate/pull/60

@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Jan 20, 2021
Merged
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@PaulDemeulenaere PaulDemeulenaere Awaiting requested review from PaulDemeulenaere

Assignees
No one assigned
Labels
testing vfx XR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabien-unity @PaulDemeulenaere @sebastienlagarde