[HDRP] Fix GC allocs #3136
Merged
[HDRP] Fix GC allocs #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Jan 15, 2021
Merged
sebastienlagarde
added
backported-10.x
needs-backport-10.x
needs-backport-2021.1
and removed
needs-backport-10.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The GC allocs were caused by assigning the "name" variable of the custom pass UnityEngine.Object.
I have tried to move this to OnEnable, but the gc allocs were still flagged, so I removed it completely.
The side-effect is that the custom passes will appear anonymous in RenderDoc captures.
Testing status
The 2 extra GC allocs are not happening anymore.