Disable Universal on Win_DX12_playmode_XR #2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sophiaaar
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Universal on Win_DX12_playmode_XR was added on Dec. 10th here. But we never got it to work.
@fabien-unity is working on a new PR that will refactor the XR tests soon, so we can disable this one in the meantime.
Testing status
Testing that the job was removed from the nightly: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Fdisable-urpdx12-playmode-xr/.yamato%252F_abv.yml%2523all_project_ci_nightly_trunk/4779165/job/pipeline (canceled because results are irrelevant)