Skip to content

Update 5001_Fog_FogFallBack scene to correct bad behavior #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 7, 2021
Merged

Update 5001_Fog_FogFallBack scene to correct bad behavior #2989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a52f590
Fix random warnings (#2972)
FrancescoC-unity Dec 21, 2020
a167ca2
Fix FreeCamera speed boost controls (#2967)
akerfoot Dec 21, 2020
5e99f9b
Fixed an issue with the frame count management for the volumetric fog…
anisunity Dec 21, 2020
38465f4
- Changed the convergance time of ssgi to 16 frames. (#2912)
anisunity Dec 21, 2020
a7fcb4e
Fix BakeCloudShadows warning
sebastienlagarde Dec 22, 2020
eeca6da
Merge branch 'master' into hd/bugfix
sebastienlagarde Dec 22, 2020
06c6d4d
Merge branch 'master' into hd/bugfix
sebastienlagarde Dec 23, 2020
6fe4862
Cleanup CubeToPanoMaterial not used
sebastienlagarde Dec 23, 2020
4aa6fc0
Update 5001_Fog_FogFallBack scene to correct bad behavior
anisunity Dec 23, 2020
be8f3a3
Updating screenshots
anisunity Dec 23, 2020
d4b200e
Increase waitFrames from 0 to 4 for test scene 5001
fabien-unity Jan 6, 2021
d88657b
Merge branch 'master' into HDRP/fix-5001-fog-fallback
sebastienlagarde Jan 7, 2021
fa1ecc3
update vulkan screenshots
sebastienlagarde Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,194 changes: 895 additions & 299 deletions TestProjects/HDRP_Tests/Assets/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback.unity
View file
Open in desktop

Large diffs are not rendered by default.

38 changes: 38 additions & 0 deletions .../Assets/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback/FogFallbackRT.renderTexture
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!84 &8400000
RenderTexture:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_Name: FogFallbackRT
m_ImageContentsHash:
serializedVersion: 2
Hash: 00000000000000000000000000000000
m_ForcedFallbackFormat: 4
m_DownscaleFallback: 0
m_IsAlphaChannelOptional: 0
serializedVersion: 3
m_Width: 640
m_Height: 360
m_AntiAliasing: 1
m_MipCount: -1
m_DepthFormat: 2
m_ColorFormat: 4
m_MipMap: 0
m_GenerateMips: 1
m_SRGB: 1
m_UseDynamicScale: 0
m_BindMS: 0
m_EnableCompatibleFormat: 0
m_TextureSettings:
serializedVersion: 2
m_FilterMode: 1
m_Aniso: 0
m_MipBias: 0
m_WrapU: 1
m_WrapV: 1
m_WrapW: 1
m_Dimension: 2
m_VolumeDepth: 1
8 changes: 8 additions & 0 deletions ...ts/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback/FogFallbackRT.renderTexture.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

166 changes: 160 additions & 6 deletions ...s/HDRP_Tests/Assets/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback/Volume_02.asset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ MonoBehaviour:
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
quality:
m_OverrideState: 0
m_Value: 1
enabled:
m_OverrideState: 1
m_Value: 1
Expand All @@ -26,6 +29,12 @@ MonoBehaviour:
hdr: 1
showAlpha: 0
showEyeDropper: 1
tint:
m_OverrideState: 0
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 1
showAlpha: 0
showEyeDropper: 1
maxFogDistance:
m_OverrideState: 0
m_Value: 5000
Expand All @@ -49,29 +58,146 @@ MonoBehaviour:
maximumHeight:
m_OverrideState: 0
m_Value: 50
meanFreePath:
m_OverrideState: 0
m_Value: 400
min: 1
enableVolumetricFog:
m_OverrideState: 0
m_Value: 0
albedo:
m_OverrideState: 0
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
meanFreePath:
globalLightProbeDimmer:
m_OverrideState: 0
m_Value: 400
min: 1
enableVolumetricFog:
m_Value: 1
min: 0
max: 1
depthExtent:
m_OverrideState: 0
m_Value: 0
m_Value: 64
min: 0.1
denoisingMode:
m_OverrideState: 0
m_Value: 2
anisotropy:
m_OverrideState: 0
m_Value: 0
min: -1
max: 1
globalLightProbeDimmer:
sliceDistributionUniformity:
m_OverrideState: 0
m_Value: 0.75
min: 0
max: 1
m_FogControlMode:
m_OverrideState: 0
m_Value: 0
screenResolutionPercentage:
m_OverrideState: 0
m_Value: 12.5
min: 6.25
max: 50
volumeSliceCount:
m_OverrideState: 0
m_Value: 64
min: 1
max: 512
m_VolumetricFogBudget:
m_OverrideState: 0
m_Value: 0.33
min: 0
max: 1
m_ResolutionDepthRatio:
m_OverrideState: 0
m_Value: 0.666
min: 0
max: 1
directionalLightsOnly:
m_OverrideState: 0
m_Value: 0
--- !u!114 &-1075090289917962011
MonoBehaviour:
m_ObjectHideFlags: 3
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 3df29e7cc05fbec4aa43e06ea875565d, type: 3}
m_Name: ProceduralSky
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
rotation:
m_OverrideState: 1
m_Value: 0
min: 0
max: 360
skyIntensityMode:
m_OverrideState: 1
m_Value: 0
exposure:
m_OverrideState: 1
m_Value: 1
multiplier:
m_OverrideState: 1
m_Value: 1
min: 0
upperHemisphereLuxValue:
m_OverrideState: 1
m_Value: 1
min: 0
upperHemisphereLuxColor:
m_OverrideState: 0
m_Value: {x: 0, y: 0, z: 0}
desiredLuxValue:
m_OverrideState: 1
m_Value: 20000
updateMode:
m_OverrideState: 1
m_Value: 0
updatePeriod:
m_OverrideState: 1
m_Value: 0
min: 0
includeSunInBaking:
m_OverrideState: 1
m_Value: 0
sunSize:
m_OverrideState: 1
m_Value: 0.04
min: 0
max: 1
sunSizeConvergence:
m_OverrideState: 1
m_Value: 5
min: 1
max: 10
atmosphereThickness:
m_OverrideState: 1
m_Value: 1
min: 0
max: 5
skyTint:
m_OverrideState: 1
m_Value: {r: 0.5, g: 0.5, b: 0.5, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
groundColor:
m_OverrideState: 1
m_Value: {r: 0.369, g: 0.349, b: 0.341, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
enableSunDisk:
m_OverrideState: 1
m_Value: 1
--- !u!114 &11400000
MonoBehaviour:
m_ObjectHideFlags: 0
Expand All @@ -86,3 +212,31 @@ MonoBehaviour:
m_EditorClassIdentifier:
components:
- {fileID: -9013707545174552859}
- {fileID: 6396251953645422251}
- {fileID: -1075090289917962011}
--- !u!114 &6396251953645422251
MonoBehaviour:
m_ObjectHideFlags: 3
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 0d7593b3a9277ac4696b20006c21dde2, type: 3}
m_Name: VisualEnvironment
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
skyType:
m_OverrideState: 1
m_Value: 4
cloudType:
m_OverrideState: 0
m_Value: 0
skyAmbientMode:
m_OverrideState: 0
m_Value: 0
fogType:
m_OverrideState: 0
m_Value: 0
122 changes: 122 additions & 0 deletions ...s/HDRP_Tests/Assets/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback/Volume_03.asset
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,122 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!114 &11400000
MonoBehaviour:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: d7fd9488000d3734a9e00ee676215985, type: 3}
m_Name: Volume_03
m_EditorClassIdentifier:
components:
- {fileID: 8902598455958804791}
- {fileID: 4246312208630799846}
--- !u!114 &4246312208630799846
MonoBehaviour:
m_ObjectHideFlags: 3
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 0d7593b3a9277ac4696b20006c21dde2, type: 3}
m_Name: VisualEnvironment
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
skyType:
m_OverrideState: 1
m_Value: 2
cloudType:
m_OverrideState: 0
m_Value: 0
skyAmbientMode:
m_OverrideState: 0
m_Value: 0
fogType:
m_OverrideState: 0
m_Value: 0
--- !u!114 &8902598455958804791
MonoBehaviour:
m_ObjectHideFlags: 3
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 3df29e7cc05fbec4aa43e06ea875565d, type: 3}
m_Name: ProceduralSky
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
rotation:
m_OverrideState: 1
m_Value: 0
min: 0
max: 360
skyIntensityMode:
m_OverrideState: 1
m_Value: 0
exposure:
m_OverrideState: 1
m_Value: 1
multiplier:
m_OverrideState: 1
m_Value: 1
min: 0
upperHemisphereLuxValue:
m_OverrideState: 1
m_Value: 1
min: 0
upperHemisphereLuxColor:
m_OverrideState: 0
m_Value: {x: 0, y: 0, z: 0}
desiredLuxValue:
m_OverrideState: 1
m_Value: 20000
updateMode:
m_OverrideState: 1
m_Value: 0
updatePeriod:
m_OverrideState: 1
m_Value: 0
min: 0
includeSunInBaking:
m_OverrideState: 1
m_Value: 0
sunSize:
m_OverrideState: 1
m_Value: 0.04
min: 0
max: 1
sunSizeConvergence:
m_OverrideState: 1
m_Value: 5
min: 1
max: 10
atmosphereThickness:
m_OverrideState: 1
m_Value: 1
min: 0
max: 5
skyTint:
m_OverrideState: 1
m_Value: {r: 0.5, g: 0.5, b: 0.5, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
groundColor:
m_OverrideState: 1
m_Value: {r: 0.369, g: 0.349, b: 0.341, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
enableSunDisk:
m_OverrideState: 1
m_Value: 1
8 changes: 8 additions & 0 deletions ...P_Tests/Assets/GraphicTests/Scenes/5x_SkyAndFog/5001_Fog_FogFallback/Volume_03.asset.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading