Skip to content

Fix out of memory crash for dX12 and vulkan on Yamato #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix out of memory crash for dX12 and vulkan on Yamato #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion com.unity.render-pipelines.high-definition/Editor/Lighting/Reflection/HDCubemapInspector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ public override Texture2D RenderStaticPreview(string assetPath, Object[] subAsse
m_PreviewUtility.ambientColor = Color.black;
m_PreviewUtility.BeginStaticPreview(new Rect(0, 0, width, height));
m_PreviewUtility.DrawMesh(sphereMesh, Matrix4x4.identity, previewMaterial, 0);
m_PreviewUtility.camera.Render();
// TODO: For now we comment this line as it cause out of memory on both DX12 and Vulkan API.
// We will need to invest time to understand what is happening
// For now priority is to enable Yamato platform automation
// This mean that cubemap icon will render incorrectly
//m_PreviewUtility.camera.Render();

var outTexture = m_PreviewUtility.EndStaticPreview();

Expand Down