Skip to content

Fix volumetric fog with XR single-pass #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Fix volumetric fog with XR single-pass #2823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37036cc
fix volumetric fog with XR single-pass rendering
fabien-unity Dec 2, 2020
e2aeb94
update changelog
fabien-unity Dec 2, 2020
36a9ab2
Merge branch 'master' into HDRP/xr/fix-volumetric-fog-quality-preset
sebastienlagarde Dec 15, 2020
822e1e8
Merge branch 'hd/bugfix' into HDRP/xr/fix-volumetric-fog-quality-preset
sebastienlagarde Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed wrong coat normal space in shader graph
- Fixed issue with faulty shadow transition when view is close to an object under some aspect ratio conditions
- Fixed NullPointerException when baking probes from the lighting window (case 1289680)
- Fixed volumetric fog with XR single-pass rendering.

### Changed
- Removed the material pass probe volumes evaluation mode.
Expand Down
4 changes: 3 additions & 1 deletion ...ender-pipelines.high-definition/Runtime/Lighting/VolumetricLighting/VolumetricLighting.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,9 @@ static internal Vector3Int ComputeVolumetricViewportSize(HDCamera hdCamera, ref

int w = Mathf.RoundToInt(viewportWidth * screenFraction);
int h = Mathf.RoundToInt(viewportHeight * screenFraction);
int d = sliceCount;

// Round to nearest multiple of viewCount so that each views have the exact same number of slices (important for XR)
int d = hdCamera.viewCount * Mathf.CeilToInt(sliceCount / hdCamera.viewCount);

return new Vector3Int(w, h, d);
}
Expand Down