[HDRP] Fixed max shadow crash #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alelievr
requested review from
sebastienlagarde,
JulienIgnace-Unity,
FrancescoC-unity and
a team
|
This LGTM, but can you check if all is fine when having cached shadows? (Update mode set to OnEnable/OnDemand) |
JulienIgnace-Unity
approved these changes
Nov 26, 2020
|
@FrancescoC-unity I played with those options and nothing unexpected (no shadows). |
FrancescoC-unity
approved these changes
Nov 26, 2020
TomasKiniulis
suggested changes
Nov 27, 2020
There was a problem hiding this comment.
@alelievr I can't get this working. After setting max shadows even with clean template library along the repro steps it still gives me the following:
ArgumentException: ComputeBuffer.SetData() : Accessing 832 bytes at offset 0 for Compute Buffer of size 208 bytes is not possible.
UnityEngine.ComputeBuffer.SetData[T] (System.Collections.Generic.List`1[T] data) (at <da7cdc01e3cf4ce5b78778fcf6bb28ca>:0)
UnityEngine.Rendering.HighDefinition.HDShadowManager.PrepareGPUShadowDatas (UnityEngine.Rendering.CullingResults cullResults, UnityEngine.Rendering.HighDefinition.HDCamera camera) (at C:/Users/Tomas/Documents/Github_Projects/Graphics2/com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs:706)
UnityEngine.Rendering.HighDefinition.HDRenderPipeline.PrepareLightsForGPU (UnityEngine.Rendering.CommandBuffer cmd, UnityEngine.Rendering.HighDefinition.HDCamera hdCamera, UnityEngine.Rendering.CullingResults cullResults, UnityEngine.Rendering.HighDefinition.HDProbeCullingResults hdProbeCullingResults, UnityEngine.Rendering.HighDefinition.DensityVolumeList densityVolumes, UnityEngine.Rendering.HighDefinition.ProbeVolumeList probeVolumes, UnityEngine.Rendering.HighDefinition.DebugDisplaySettings debugDisplaySettings, UnityEngine.Rendering.HighDefinition.AOVRequestData aovRequest) (at C:/Users/Tomas/Documents/Github_Projects/Graphics2/com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs:2753)
Shadows are not displayed correctly without error spam only after reopening the project, but setting shadows above from zero and back to zero brings the issue back
TomasKiniulis
approved these changes
Nov 27, 2020
sebastienlagarde
approved these changes
Nov 27, 2020
Merged
sebastienlagarde
added a commit
that referenced
this pull request
Nov 30, 2020
* Fixed volume component tooltips using the same parameter name (#2754) * Use the proper history info for Bicubic resampling in TAA (#2759) * Use proper info for previous buffer info * changelog * Fixed lookdev movement (#2757) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix issue with saving some quality settings in volume overrides (#2758) * Fix issue with saving some quality settings volume overrides * Fix typo in changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fixed NullReferenceException in HDRenderPipeline.UpgradeResourcesIfNeeded (case 1292524) (#2765) * fix issue with confusing text (#2766) * Fixed SSGI texture allocation with RG disabled (#2768) * [HDRP] Fixed max shadow crash (#2760) * Fixed NullReference Exception when setting Max Shadows On Screen to 0 in the HDRP asset * Updated changelog * Fixed nullref again + debug * Initialize shadow request count Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Formatting * Update CHANGELOG.md Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix this issue: https://fogbugz.unity3d.com/f/cases/1290357/
Backport case for 10.3: https://fogbugz.unity3d.com/f/cases/1294583/
Note: To avoid paying the CPU cost of culling for shadows that we won't use, I disabled the
ShadowCastersflag on the culling options when shadows are disabled.We don't allocate the shadow atlases anymore either.
Testing status
Manually tested with the template scene, now setting max shadows on screen does not produce any error.
Comments to reviewers
There might be some side effects on the shader variable side, even if we shouldn't use them when shadows are disabled. But I haven't encountered this case while testing.