Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yamato] Add variable for testfilter #2696

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Conversation

kivistikliis
Copy link
Contributor

@kivistikliis kivistikliis commented Nov 20, 2020


Purpose of this PR

Adds Yamato variable for testfilter with default value .*, ie --testfilter=.*, for standalone build/playmode/editmode.
This allows to run a subset of tests in Yamato.

  1. Note that setting the variable affects all jobs in the pipeline for which the flag is not hardcoded in yml (only a few specific jobs have it hardcoded)
  2. Note that for the jobs which have a hardcoded testfilter flag (eg urp performance boatattack jobs), the variable is still available but stays unused (ie whatever is hardcoded is used). To see if the job has it hardcoded, simply check if the variable is referenced in the yml utr command or not (or alternatively check the utr_flags section in metafiles)

Testing status

Universal with default .* https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ftest-filter-variable-2/.yamato%252Fall-universal.yml%2523All_Universal_trunk/4289717/job

Universal with only ImageAssertTests https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ftest-filter-variable-2/.yamato%252Fall-universal.yml%2523All_Universal_trunk/4289729/job

Nightly to check all platforms with default https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Ftest-filter-variable-2/.yamato%252F_abv.yml%2523all_project_ci_nightly_trunk/4292692/job/pipeline

@kivistikliis kivistikliis requested a review from a team November 20, 2020 13:48
# Conflicts:
#	.yamato/all-shadergraph.yml
#	.yamato/all-universal_hybrid.yml
@kivistikliis kivistikliis marked this pull request as ready for review November 24, 2020 09:47
@sophiaaar
Copy link
Contributor

please add some docs about this new feature :)

@sophiaaar sophiaaar merged commit bb0c2b5 into master Nov 24, 2020
@sophiaaar sophiaaar deleted the yamato/test-filter-variable-2 branch November 24, 2020 16:08
sebastienlagarde added a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants