Skip to content

[HDRP] Fix runtime debug UI showing wrong entry #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

[HDRP] Fix runtime debug UI showing wrong entry #2595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7012f
Redraw debug before re-registring the debugs
FrancescoC-unity Nov 12, 2020
eb2ae47
changelog
FrancescoC-unity Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Fixed
- Fixed probe volumes debug views.
- Fixed issue displaying wrong debug mode in runtime debug menu UI.

## [10.2.0] - 2020-10-19

Expand Down
18 changes: 12 additions & 6 deletions com.unity.render-pipelines.high-definition/Runtime/Debug/DebugDisplay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,56 +1008,62 @@ void RegisterMaterialDebug()
void RefreshDisplayStatsDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelDisplayStats, m_DebugDisplayStatsItems);
RegisterDisplayStatsDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterDisplayStatsDebug();
}

// For now we just rebuild the lighting panel if needed, but ultimately it could be done in a better way
void RefreshLightingDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelLighting, m_DebugLightingItems);
RegisterLightingDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterLightingDebug();
}

void RefreshDecalsDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelDecals, m_DebugDecalsAffectingTransparentItems);
RegisterDecalsDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterDecalsDebug();
}

void RefreshRenderingDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelRendering, m_DebugRenderingItems);
RegisterRenderingDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterRenderingDebug();
}

void RefreshMaterialDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelMaterials, m_DebugMaterialItems);
RegisterMaterialDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterMaterialDebug();
}

void RefreshVolumeDebug<T>(DebugUI.Field<T> field, T value)
{
UnregisterDebugItems(k_PanelVolume, m_DebugVolumeItems);
RegisterVolumeDebug();

if (DebugManager.instance.displayRuntimeUI)
DebugManager.instance.ReDrawOnScreenDebug();

RegisterVolumeDebug();
}

void RegisterLightingDebug()
Expand Down