Skip to content

hdr toggle issues in scene view #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

martint-unity
Copy link
Contributor


Purpose of this PR

Fixing an issue where scene view camera ignored the HDR toggle from the Universal Pipeline Asset.
https://fogbugz.unity3d.com/f/cases/1284369/

fix_hdr_toggle

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified issue 1284369, checked all combinations of HDR settings:

  • Main Camera Off + URP Asset true
  • Main Camera "Use pipeline settings" + URP Asset true
  • Main Camera "Use pipeline settings" + URP Asset false.

All combinations result in Scene View Camera having same HDR settings as the Main Camera.

@pbbastian pbbastian merged commit a32840b into master Nov 6, 2020
@pbbastian pbbastian deleted the universal/bugfix/hdr-toggle-sceneview branch November 6, 2020 09:34
@martint-unity
Copy link
Contributor Author

Removing the tag to 10, since it is working in 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants