Skip to content

Fix volument component creation via script #2337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

adrien-de-tocqueville
Copy link
Contributor

Purpose of this PR

Fix for https://fogbugz.unity3d.com/f/cases/1284935/

Creating a volume component by script corrupts the volume profile.


Testing status

I tested the repro script of the case, the profile is not corrupted anymore

anisunity and others added 11 commits October 22, 2020 16:35
* Add frame setting

* changelog

* Grey setting out and make it always available.

* Reverts tuff meant for antoher branch

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Rename function

* Undoable "enable compositor"

* Undo/Redo Enable/Disable compositor

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
* Improved the punctual shadow algorithm (it's less agressive now)

* Updated changelog
* Fixed a nullref when a diffusion profile was created

* Updated changelog

* Trying to fix diffusion profile asset dependency

* Fixed export as package

* Updated changelog

Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
… into hd/bugfix

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md
Base automatically changed from hd/bugfix to master October 24, 2020 23:27
@adrien-de-tocqueville adrien-de-tocqueville removed the request for review from sebastienlagarde October 26, 2020 10:58
@adrien-de-tocqueville
Copy link
Contributor Author

#2369

@adrien-de-tocqueville adrien-de-tocqueville deleted the hd/fix-volume-corrupt branch October 30, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants