Skip to content

Restore correct cullmode for SceneSelectionPass #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed after post process rendering pass options not showing for unlit ShaderGraphs.
- Fixed a migration issue with the rendering queue in ShaderGraph when upgrading to 10.x;
- Fixed null reference in the Undo callback of the graphics compositor
- Fixed cullmode for SceneSelectionPass.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -596,6 +596,7 @@ public static class Uniforms

public static RenderStateCollection SceneSelection = new RenderStateCollection
{
{ RenderState.Cull(Cull.Off) },
{ RenderState.ColorMask("ColorMask 0") },
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ Shader "HDRP/AxF"
Name "SceneSelectionPass"
Tags { "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

HLSLPROGRAM

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ Shader "HDRP/LayeredLit"
Name "SceneSelectionPass"
Tags{ "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

HLSLPROGRAM

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ Shader "HDRP/LayeredLitTessellation"
Name "SceneSelectionPass"
Tags{ "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

ZWrite On

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ Shader "HDRP/Lit"
Name "SceneSelectionPass"
Tags { "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

HLSLPROGRAM

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ Shader "HDRP/LitTessellation"
Name "SceneSelectionPass"
Tags { "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

HLSLPROGRAM

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ Shader "HDRP/TerrainLit"
Name "SceneSelectionPass"
Tags { "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

HLSLPROGRAM

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Shader "HDRP/Unlit"
Name "SceneSelectionPass"
Tags{ "LightMode" = "SceneSelectionPass" }

Cull[_CullMode]
Cull Off

ZWrite On

Expand Down