Fix wrong error thrown on DXR wizard fixup #2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienlagarde
approved these changes
Oct 8, 2020
TomasKiniulis
approved these changes
Oct 8, 2020
sebastienlagarde
deleted the
HDRP/error-on-dxr-hw-support-only-on-d3d12
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1263049/
Turns out SystemInfo.supportsRayTracing returns false for every device but D3D12, however the error message is confusing implying that the issue is not on the device type but is an hardware/OS issue.
Upon fixing all, the API is set to D3D11 before the restart, hence it throws an error even though there is no real issue.
I modified the error and what gets triggered at what stage in a way that we don't mention wrong hw unless we are sure that D3D12 is already set.