Skip to content

Disable shader debug symbols #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented Oct 8, 2020

Purpose of this PR

Disable shader debug symbols + reduce build size


Testing status

I only check that it compiles.

@github-actions
Copy link

github-actions bot commented Oct 8, 2020

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

Copy link
Contributor

@jenniferd-unity jenniferd-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on a DX11 build. Reduced size of the CustomPassUtils.shader from 1.39MB to 11kB.

@sebastienlagarde
Copy link
Contributor

yeah those stuff save a lot, good catch :)

@sebastienlagarde sebastienlagarde merged commit f8e87ea into HDRP/staging Oct 8, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/fix/disable-debug-shaders branch October 8, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants