Improve Light Unit Slider UX #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture gradient texture
johnpars
requested review from
MaddalenaUnity-zz,
sebastienlagarde,
iM0ve,
RSlysz,
fredericv-unity3d and
eturquin
sebastienlagarde
approved these changes
Oct 8, 2020
sebastienlagarde
requested review from
a team
and removed request for
fredericv-unity3d
|
@iM0ve I will merge this one for 10.1 package as it fix a wrong behavior so it is important, but still provide your QA pass feedback here. THanks |
|
Testing seems sufficient, but I will check on the next 10.1 package revision |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR introduces various fixes, additions & improvements to the light unit UX as requested by artist and UX team, namely:
1) Replaced Icons
Icons for Fluorescent, Shade, Blue Sky were added to the temperature slider.
2) Preset Context Menu
Clicking on the icon will present a list of presets to the user. Clicking on them will place the value in a recommended preset value in a value range, which is set by artist (in reference to this table).
3) Undo/Redo
Replicating the breaking case as pointed out by @iM0ve- it should now be fixed.
4) Fixed alignment of 6500 Kelvin
Before:
After:
As the temperature tooltip states, 6500 Kelvin must be equivalent to the white point. Prior to this PR, this was not reflected in the new slider UI, but now it will be true.
5) Correction to spot reflector behavior
Before:
After:
Prior to this PR, spot light + reflector actually broke the nature of radiance units (like Candela), since they could be changed based on the shape of the spot light. After long discussion with artist + engineer, this is the acceptable way forward to correct the issue, with plans in the future for further improvement on the spot light case. Feel free to follow the conversation here and here.
6) The spacing between icon and slider was removed, so that it is aligned with the rest of the inspector.
Testing status
Tested these changes to the editor locally on two of my machines.
Comments to reviewers