Skip to content

Added tooltip to micro shadows #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Added tooltip to micro shadows #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed outlines in transitions between post-processed and plain regions in the graphics compositor (case 1278775).
- Fix decal being applied twice with LOD Crossfade.
- Fixed camera stacking for AOVs in the graphics compositor (case 1273223).
- Added a tooltip to the Micro Shadows parameters (case 1282692).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also edit the documentation of micro shadow volume

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc already mentions it


### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/MicroShadowing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ public class MicroShadowing : VolumeComponent
/// <summary>
/// When enabled, HDRP processes Micro Shadows for this Volume.
/// </summary>
[Tooltip("Enables micro shadows for directional lights.")]
public BoolParameter enable = new BoolParameter(false);

/// <summary>
/// Controls the opacity of the micro shadows.
/// </summary>
[Tooltip("Controls the opacity of the micro shadows.")]
public ClampedFloatParameter opacity = new ClampedFloatParameter(1.0f, 0.0f, 1.0f);

MicroShadowing()
Expand Down