Skip to content

Meshes with decal material not added to RT acceleration structure anymore #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2020
Merged

Meshes with decal material not added to RT acceleration structure anymore #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36786b5
Test that a material is non-decal before adding corresp. mesh to the …
eturquin Oct 2, 2020
778c36c
Updated changelog.
eturquin Oct 2, 2020
09566a5
Update HDRaytracingManager.cs
sebastienlagarde Oct 3, 2020
75b1a58
Merge branch 'HDRP/staging' into HDRP/rt_decal_mtl
sebastienlagarde Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Improved MSAA color resolve to fix issues when very bright and very dark samples are resolved together.
- Improve performance of GPU light AABB generation
- Removed the max clamp value for the RTR, RTAO and RTGI's ray length (case 1279849).
- Meshes assigned with a decal material are not visible anymore in ray-tracing or path-tracing.

## [10.0.0] - 2019-06-10

Expand Down
6 changes: 3 additions & 3 deletions ...render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/HDRaytracingManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ AccelerationStructureStatus AddInstanceToRAS(Renderer currentRenderer,
// Grab the material for the current sub-mesh
Material currentMaterial = materialArray[meshIdx];

// The material is transparent if either it has the requested keyword or is in the transparent queue range
if (currentMaterial != null)
// Make sure that the material is both non-null and non-decal
if (currentMaterial != null && !DecalSystem.IsDecalMaterial(currentMaterial))
{
// Mesh is valid given that all requirements are ok
validMesh = true;
Expand All @@ -233,7 +233,7 @@ AccelerationStructureStatus AddInstanceToRAS(Renderer currentRenderer,
|| (HDRenderQueue.k_RenderQueue_Transparent.lowerBound <= currentMaterial.renderQueue
&& HDRenderQueue.k_RenderQueue_Transparent.upperBound >= currentMaterial.renderQueue);

// aggregate the transparency info
// Aggregate the transparency info
materialIsOnlyTransparent &= subMeshTransparentArray[meshIdx];
hasTransparentSubMaterial |= subMeshTransparentArray[meshIdx];

Expand Down