Add project logs to artifacts #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivistikliis
changed the title
theopnv
approved these changes
Oct 5, 2020
added 2 commits
October 5, 2020 12:59
# Conflicts: # .yamato/hdrp-linux-vulkan.yml # .yamato/hdrp-osx-metal.yml # .yamato/hdrp-win-dx11.yml # .yamato/hdrp-win-dx12.yml # .yamato/hdrp-win-vulkan.yml # .yamato/hdrp_dxr-win-dx12.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Includes
<project_folder>/Logs/*.logfiles to job artifacts.Testing status
Ran All ShaderGraph CI https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Flogs-to-artifacts/.yamato%252Fall-shadergraph.yml%2523All_ShaderGraph_trunk/3627119/job/artifacts
ShaderGraph_Win_DX11_playmode_trunk, then navigate to the artifacts of this specific job. (The path to logs is the same for all jobs for a certain project, so the artifacts of the parent-job correspond to the last child-job that ran, because that last job overwrites whatever artifact the previous child-job produced)Comments to reviewers
to navigate easier between all the changes, the logs were added to jobs in https://github.com/Unity-Technologies/Graphics/compare/yamato/logs-to-artifacts#diff-18dce6dde809c1b60a1702f03dbb1496R28