Fix "ToSubgraph" with multiple outputs and allow passthrough #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckboard consistent with how nodes behave in searching for properties/keywords
cdxntchou
approved these changes
Oct 6, 2020
GrantLamb-Unity
requested review from
GrantLamb-Unity and
a user
and removed request for
a team and
GrantLamb-Unity
ghost
approved these changes
Oct 21, 2020
ghost
self-requested a review
ghost
suggested changes
Oct 21, 2020
ghost
approved these changes
Oct 21, 2020
marctem
approved these changes
Oct 21, 2020
…ogies/Graphics into sg/fix-mult-output-convert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to fix how we create the subgraph when using the contextual "ToSubgraph" option in the MaterialGraphEditWindow. Depends on fixes to property copying from #1932
for https://fogbugz.unity3d.com/f/cases/1256975/
redid repro steps and could not get bug to occur