-
Notifications
You must be signed in to change notification settings - Fork 840
Fixed error Maximum allowed thread group count is 65535 when resolution is very high. #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
016b596
Fix issue when we need more than 65535
FrancescoC-unity a812793
Changelog
FrancescoC-unity 2213dde
Push rest of file
FrancescoC-unity 8b34913
Merge branch 'HDRP/staging' into HDRP/fix-max-thread-count-bug
sebastienlagarde de57453
Missing offset
FrancescoC-unity b2b7158
Merge branch 'HDRP/staging' into HDRP/fix-max-thread-count-bug
sebastienlagarde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 6 additions & 3 deletions
9
...unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/ClearLightLists.compute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
#pragma kernel ClearList | ||
|
||
RWStructuredBuffer<uint> _LightListToClear; | ||
int _LightListEntries; | ||
int2 _LightListEntriesAndOffset; | ||
|
||
#define _LightListEntries (uint)_LightListEntriesAndOffset.x | ||
#define _LightListOffset (uint)_LightListEntriesAndOffset.y | ||
|
||
[numthreads(64, 1, 1)] | ||
void ClearList(uint3 id : SV_DispatchThreadID) | ||
{ | ||
if (id.x < (uint)_LightListEntries) | ||
_LightListToClear[id.x] = 0; | ||
if ((id.x + _LightListOffset) < (uint)_LightListEntries) | ||
_LightListToClear[id.x + _LightListOffset] = 0; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do'nt used _LightListOffset in the code, don't think it is expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shoot, forgot to stage the full file! Staging now and pushing