Skip to content

Fix cubemap static preview + remove custom inspector #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed an issue where entering playmode would close the LookDev window.
- Fixed Cutoff not working properly with ray tracing shaders default and SG (case 1261292).
- Fixed shader compilation issue with Hair shader and debug display mode
- Fixed cubemap static preview not updated when the asset is imported.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace UnityEditor.Rendering.HighDefinition
{
sealed partial class HDReflectionProbeEditor
{
HDCubemapInspector m_CubemapEditor;
Editor m_CubemapEditor;

public override bool HasPreviewGUI()
{
Expand All @@ -22,8 +22,7 @@ public override bool HasPreviewGUI()
if (ValidPreviewSetup() && m_CubemapEditor == null)
{
Editor editor = m_CubemapEditor;
CreateCachedEditor(GetTexture(this, target), typeof(HDCubemapInspector), ref editor);
m_CubemapEditor = editor as HDCubemapInspector;
m_CubemapEditor = CreateEditor(GetTexture(this, target));
}

// If having one probe selected we always want preview (to prevent preview window from popping)
Expand Down