Skip to content

Fixed save popup appearing twice #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Fixed save popup appearing twice #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e38b9e0
Fixed save popup appearing twice
adrien-de-tocqueville Sep 24, 2020
325bf1c
Merge branch 'HDRP/staging' into HDRP/fix-1264774
sebastienlagarde Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed wizard DXR setup on non-DXR compatible devices.
- Fixed Custom Post Processes affecting preview cameras.
- Fixed issue with lens distortion breaking rendering.
- Fixed save popup appearing twice due to HDRP wizard.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
10 changes: 3 additions & 7 deletions com.unity.render-pipelines.high-definition/Editor/Wizard/HDWizard.Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,15 +610,11 @@ void ChangedFirstGraphicAPI(BuildTarget target)
if (WillEditorUseFirstGraphicsAPI(target))
{
if (EditorUtility.DisplayDialog("Changing editor graphics device",
"You've changed the active graphics API. This requires a restart of the Editor. After restarting finish fixing DXR configuration by launching the wizard again.",
"You've changed the active graphics API. This requires a restart of the Editor. After restarting, finish fixing DXR configuration by launching the wizard again.",
"Restart Editor", "Not now"))
{
if (EditorSceneManager.SaveCurrentModifiedScenesIfUserWantsTo())
{
HDProjectSettings.wizardNeedRestartAfterChangingToDX12 = false;
RequestCloseAndRelaunchWithCurrentArguments();
GUIUtility.ExitGUI();
}
HDProjectSettings.wizardNeedRestartAfterChangingToDX12 = false;
RequestCloseAndRelaunchWithCurrentArguments();
}
else
EditorApplication.quitting += () => HDProjectSettings.wizardNeedRestartAfterChangingToDX12 = false;
Expand Down