Skip to content

fix case 1244430 removing camera comp from prefab #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a warning in materialevalulation
- Fixed an error when building the player.
- Fixed issue with box light not visible if range is below one and range attenuation is off.
- Fixed an issue that caused a null reference when deleting camera component in a prefab. (case 1244430)

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,32 @@ public void RemoveComponent(Camera camera, IEnumerable<Component> dependencies)
return;
}

Undo.SetCurrentGroupName("Remove HD Camera");
var additionalCameraData = camera.GetComponent<HDAdditionalCameraData>();
if (additionalCameraData)
var isAssetEditing = EditorUtility.IsPersistent(camera);
try
{
Undo.DestroyObjectImmediate(additionalCameraData);
if (isAssetEditing)
{
AssetDatabase.StartAssetEditing();
}

Undo.SetCurrentGroupName("Remove HD Camera");
var additionalCameraData = camera.GetComponent<HDAdditionalCameraData>();
if (additionalCameraData != null)
{
Undo.DestroyObjectImmediate(additionalCameraData);
}

Undo.DestroyObjectImmediate(camera);
}
finally
{
if (isAssetEditing)
{
AssetDatabase.StopAssetEditing();
}
}
Undo.DestroyObjectImmediate(camera);
}

[MenuItem("CONTEXT/Camera/Reset", false, 0)]
static void ResetCamera(MenuCommand menuCommand)
{
Expand Down