Skip to content

camera prefab null reference fix #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2020
Merged

camera prefab null reference fix #1898

merged 3 commits into from
Sep 23, 2020

Conversation

martint-unity
Copy link
Contributor

Purpose of this PR

Fix for this case https://fogbugz.unity3d.com/f/cases/1244430/
Removing camera component in prefab, caused a null reference.

@martint-unity martint-unity marked this pull request as ready for review September 21, 2020 06:13
@martint-unity martint-unity requested a review from a team as a code owner September 21, 2020 06:13
@madsnyholm
Copy link

@martint-unity Have you checked if this fix also needs to by applied for HDRP?

@martint-unity
Copy link
Contributor Author

@madsnyholm will check that now

@martint-unity martint-unity mentioned this pull request Sep 21, 2020
Merged
@phi-lira
Copy link
Contributor

Please add ready-to-merge tag when ABV is green and I'll merge it.

@martint-unity martint-unity added the ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV label Sep 23, 2020
@phi-lira phi-lira merged commit f936b34 into master Sep 23, 2020
@phi-lira phi-lira deleted the universal/bugfix/camera-prefab-camera-component-issue branch September 23, 2020 11:31
@phi-lira phi-lira removed the ready-to-merge Add this tag whenever your PR is ready to be merged. i.e, non draft, all reviewers approved, ABV label Sep 23, 2020
martint-unity added a commit that referenced this pull request Nov 18, 2020
@martint-unity
[8.x.x] backport of #1898 null ref in cam prefab
86f07ce
@martint-unity martint-unity mentioned this pull request Nov 18, 2020
Merged
ellioman pushed a commit that referenced this pull request Nov 18, 2020
@martint-unity
[8.x.x] backport of #1898 null ref in cam prefab (#2665)
70384b2
@martint-unity
Copy link
Contributor Author

Don't need backport to 7 since it doesnt repro there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellioman ellioman ellioman approved these changes

@madsnyholm madsnyholm madsnyholm approved these changes

@phi-lira phi-lira phi-lira approved these changes

Assignees
No one assigned
Labels
backported-8.x universal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martint-unity @madsnyholm @phi-lira @ellioman