Skip to content

Fix cookie atlas alloc for cone spot lights #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Fix cookie atlas alloc for cone spot lights #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bdadcd
Fix unneeded cookie texture allocation for cone stop lights
alelievr Apr 20, 2020
fb8e6cb
Updated changelog
alelievr Apr 20, 2020
ef23c0a
Fix cone spot light cookie
alelievr Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed PBR shader ZTest rendering in deferred.
- Replaced commands incompatible with async compute in light list build process.
- Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. Note that the diffusion profile or the material references need to be edited once before this can work properly.
- Fixed unneeded cookie texture allocation for cone stop lights.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
3 changes: 2 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2720,7 +2720,8 @@ internal void ReserveCookieAtlasTexture(HDAdditionalLightData hdLightData, Light
break;
case HDLightType.Spot:
// Projectors lights must always have a cookie texture.
m_TextureCaches.lightCookieManager.ReserveSpace(light?.cookie ?? Texture2D.whiteTexture);
if (hdLightData.spotLightShape != SpotLightShape.Cone || light?.cookie != null)
m_TextureCaches.lightCookieManager.ReserveSpace(light?.cookie ?? Texture2D.whiteTexture);
break;
case HDLightType.Area:
// Only rectnagles can have cookies
Expand Down