Skip to content

Backport 8.x.x - 1204667 - Moved Utilities namespace #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using UnityEngine.Rendering;
using Utilities;


namespace UnityEditor.Rendering.Utilities
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
using System;
using UnityEngine;
using UnityEngine.Rendering;
using UnityEngine.Scripting.APIUpdating;

namespace Utilities
namespace UnityEngine.Rendering
{
/// <summary>
/// Material quality flags.
/// </summary>
[Flags]
[MovedFrom("Utilities")]
public enum MaterialQuality
{
/// <summary>Low Material Quality.</summary>
Expand All @@ -21,6 +21,7 @@ public enum MaterialQuality
/// <summary>
/// Material Quality utility class.
/// </summary>
[MovedFrom("Utilities")]
public static class MaterialQualityUtilities
{
/// <summary>
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed warning about missing bound decal buffer
- Fixed the debug exposure mode for display sky reflection and debug view baked lighting
- Fixed shader warning on Xbox for ResolveStencilBuffer.compute.
- Renamed namespace Utilities to UnityEngine.Rendering (case 1204667)

### Changed
- Rejecting history for ray traced reflections based on a threshold evaluated on the neighborhood of the sampled history.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using UnityEngine.Rendering;
using UnityEngine.Rendering.HighDefinition;
using System.Text;
using Utilities;

using UnityEngine.Experimental.Rendering;
using static UnityEngine.Rendering.HighDefinition.RenderPipelineSettings;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using UnityEngine;
using UnityEngine.Rendering.HighDefinition;
using UnityEditor.Rendering;
using Utilities;


namespace UnityEditor.Rendering.HighDefinition
{
Expand All @@ -19,27 +19,27 @@ enum MaterialQualityMode

static class MaterialQualityModeExtensions
{
public static MaterialQuality Into(this MaterialQualityMode quality)
public static UnityEngine.Rendering.MaterialQuality Into(this MaterialQualityMode quality)
{
switch (quality)
{
case MaterialQualityMode.High: return MaterialQuality.High;
case MaterialQualityMode.Medium: return MaterialQuality.Medium;
case MaterialQualityMode.Low: return MaterialQuality.Low;
case MaterialQualityMode.FromQualitySettings: return (MaterialQuality)0;
case MaterialQualityMode.High: return UnityEngine.Rendering.MaterialQuality.High;
case MaterialQualityMode.Medium: return UnityEngine.Rendering.MaterialQuality.Medium;
case MaterialQualityMode.Low: return UnityEngine.Rendering.MaterialQuality.Low;
case MaterialQualityMode.FromQualitySettings: return (UnityEngine.Rendering.MaterialQuality)0;
default: throw new ArgumentOutOfRangeException(nameof(quality));
}
}

public static MaterialQualityMode Into(this MaterialQuality quality)
public static MaterialQualityMode Into(this UnityEngine.Rendering.MaterialQuality quality)
{
if (quality == (MaterialQuality) 0)
if (quality == (UnityEngine.Rendering.MaterialQuality) 0)
return MaterialQualityMode.FromQualitySettings;
switch (quality)
{
case MaterialQuality.High: return MaterialQualityMode.High;
case MaterialQuality.Medium: return MaterialQualityMode.Medium;
case MaterialQuality.Low: return MaterialQualityMode.Low;
case UnityEngine.Rendering.MaterialQuality.High: return MaterialQualityMode.High;
case UnityEngine.Rendering.MaterialQuality.Medium: return MaterialQualityMode.Medium;
case UnityEngine.Rendering.MaterialQuality.Low: return MaterialQualityMode.Low;
default: throw new ArgumentOutOfRangeException(nameof(quality));
}
}
Expand Down Expand Up @@ -254,7 +254,7 @@ static void Drawer_SectionRenderingSettings(SerializedFrameSettings serialized,

area.AmmendInfo(FrameSettingsField.MaterialQualityLevel,
overridedDefaultValue: defaultFrameSettings.materialQuality.Into(),
customGetter: () => ((MaterialQuality)serialized.materialQuality.intValue).Into(),
customGetter: () => ((UnityEngine.Rendering.MaterialQuality)serialized.materialQuality.intValue).Into(),
customSetter: v => serialized.materialQuality.intValue = (int)((MaterialQualityMode)v).Into()
);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
using Utilities;
using UnityEngine.Experimental.Rendering;
using UnityEngine.Experimental.Rendering.RenderGraphModule;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using UnityEngine.Experimental.GlobalIllumination;
using UnityEngine.Experimental.Rendering;
using UnityEngine.Experimental.Rendering.RenderGraphModule;
using Utilities;

namespace UnityEngine.Rendering.HighDefinition
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using System.Collections.Generic;
using UnityEngine.Serialization;
using Utilities;

namespace UnityEngine.Rendering.HighDefinition
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System.Diagnostics;
using System.Reflection;
using System.Linq;
using Utilities;

namespace UnityEngine.Rendering.HighDefinition
{
Expand Down