Skip to content

Fix compile issue on vulkan when a min16float4 is generated and shouldn't #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Fix compile issue on vulkan when a min16float4 is generated and shouldn't #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfa46dc
Avoid to generate min16float4
FrancescoC-unity Sep 11, 2020
29d3825
changelog
FrancescoC-unity Sep 11, 2020
f015bc4
Merge branch 'HDRP/staging' into HDRP/fix-vulkan-compile-issue
sebastienlagarde Oct 8, 2020
28c4cca
Merge branch 'HDRP/staging' into HDRP/fix-vulkan-compile-issue
sebastienlagarde Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed issues with bloom, alpha and HDR layers in the compositor (case 1272621).
- Fixed alpha not having TAA applied to it.
- Fix issue with alpha output in forward.
- Fix compilation issue on Vulkan for shaders using high quality shadows in XR mode.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
1 change: 0 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ struct HDShadowData
public Vector4 zBufferParam;
public Vector4 shadowMapSize;

[SurfaceDataAttributes(precision = FieldPrecision.Real)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding @jessebarker as I guess he may be the one who have done this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I added it (hard to tell - git says that line was last edited by you :-) ). The only issue I can think of is whether both C# and the generated shader struct understand the data as being the same type/layout. Shouldn't be a problem to take "Real" precision away.

public Vector4 shadowFilterParams0;

public Vector3 cacheTranslationDelta;
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/HDShadowManager.cs.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ struct HDShadowData
float normalBias;
real4 zBufferParam;
float4 shadowMapSize;
real4 shadowFilterParams0;
float4 shadowFilterParams0;
float3 cacheTranslationDelta;
float isInCachedAtlas;
float4x4 shadowToWorld;
Expand Down