Skip to content

Improvements on the volumetrics user experience #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
39f5a6b
Fixed a Nan issue in the volumetric lighting filtering.
anisunity Sep 15, 2020
65303ec
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Sep 15, 2020
edc903b
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Sep 16, 2020
aada293
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Sep 18, 2020
84887ff
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Sep 21, 2020
ba6bcfc
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Sep 25, 2020
164a9dc
Fixing compilation after bad merge
anisunity Sep 25, 2020
1ec8af7
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 4, 2020
3f758cd
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 4, 2020
e3985c5
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 8, 2020
035cc6a
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 9, 2020
c218e42
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 12, 2020
3f621a6
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 14, 2020
9d554e0
Merge branch 'HDRP/staging' into HDRP/VolumetricImprovements
sebastienlagarde Oct 16, 2020
a5140c5
Merge branch 'master' into HDRP/VolumetricImprovements
sebastienlagarde Oct 22, 2020
42ce2cd
Disable 002 and 003 test on vulkan on windows and linux as it is all …
sebastienlagarde Oct 22, 2020
d69a043
Update CHANGELOG.md
sebastienlagarde Oct 22, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions TestProjects/HDRP_RuntimeTests/Assets/TestCaseFilters.asset
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
%YAML 1.1
%TAG !u! tag:unity3d.com,2011:
--- !u!114 &11400000
MonoBehaviour:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 0}
m_Enabled: 1
m_EditorHideFlags: 0
m_Script: {fileID: 11500000, guid: 5f6aa9f32113aec4a8bded44c1febe5c, type: 3}
m_Name: TestCaseFilters
m_EditorClassIdentifier:
filters:
- FilteredScene: {fileID: 0}
FilteredScenes:
- {fileID: 102900000, guid: b0ec7521f32466147a09e7dadff3ae0e, type: 3}
ColorSpace: 1
BuildPlatform: 5
GraphicsDevice: 21
XrSdk:
StereoModes: 0
Reason: all black on Yamato but work locally
- FilteredScene: {fileID: 0}
FilteredScenes:
- {fileID: 102900000, guid: b0ec7521f32466147a09e7dadff3ae0e, type: 3}
ColorSpace: 1
BuildPlatform: 24
GraphicsDevice: 21
XrSdk:
StereoModes: 0
Reason: all black on Yamato but work locally
- FilteredScene: {fileID: 0}
FilteredScenes:
- {fileID: 102900000, guid: 897c2870240f77a46a18884a0446b797, type: 3}
ColorSpace: 1
BuildPlatform: 5
GraphicsDevice: 21
XrSdk:
StereoModes: 0
Reason: all black on Yamato but work locally
- FilteredScene: {fileID: 0}
FilteredScenes:
- {fileID: 102900000, guid: 897c2870240f77a46a18884a0446b797, type: 3}
ColorSpace: 1
BuildPlatform: 24
GraphicsDevice: 21
XrSdk:
StereoModes: 0
Reason: all black on Yamato but work locally

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ MonoBehaviour:
m_Name: Fog
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
m_AdvancedMode: 1
enabled:
m_OverrideState: 1
m_Value: 1
Expand All @@ -49,6 +49,12 @@ MonoBehaviour:
hdr: 1
showAlpha: 0
showEyeDropper: 1
tint:
m_OverrideState: 0
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 1
showAlpha: 0
showEyeDropper: 1
maxFogDistance:
m_OverrideState: 0
m_Value: 5000
Expand All @@ -72,24 +78,19 @@ MonoBehaviour:
maximumHeight:
m_OverrideState: 0
m_Value: 50
albedo:
m_OverrideState: 0
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
meanFreePath:
m_OverrideState: 1
m_Value: 3
min: 1
enableVolumetricFog:
m_OverrideState: 1
m_Value: 1
anisotropy:
albedo:
m_OverrideState: 0
m_Value: 0
min: -1
max: 1
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
globalLightProbeDimmer:
m_OverrideState: 0
m_Value: 1
Expand All @@ -99,11 +100,22 @@ MonoBehaviour:
m_OverrideState: 0
m_Value: 64
min: 0.1
denoisingMode:
m_OverrideState: 1
m_Value: 0
anisotropy:
m_OverrideState: 0
m_Value: 0
min: -1
max: 1
sliceDistributionUniformity:
m_OverrideState: 0
m_Value: 0.75
min: 0
max: 1
fogControlMode:
m_OverrideState: 1
m_Value: 1
screenResolutionPercentage:
m_OverrideState: 1
m_Value: 25
Expand All @@ -114,6 +126,19 @@ MonoBehaviour:
m_Value: 128
min: 1
max: 1024
volumetricFogBudget:
m_OverrideState: 0
m_Value: 0.25
min: 0
max: 1
resolutionDepthRatio:
m_OverrideState: 0
m_Value: 0.5
min: 0
max: 1
directionalLightsOnly:
m_OverrideState: 0
m_Value: 0
--- !u!114 &11400000
MonoBehaviour:
m_ObjectHideFlags: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ MonoBehaviour:
m_OverrideState: 1
m_Value: 1
min: 0
upperHemisphereLuxColor:
m_OverrideState: 0
m_Value: {x: 0, y: 0, z: 0}
desiredLuxValue:
m_OverrideState: 1
m_Value: 20000
Expand Down Expand Up @@ -130,7 +133,7 @@ MonoBehaviour:
m_Name:
m_EditorClassIdentifier:
active: 1
m_AdvancedMode: 0
m_AdvancedMode: 1
enabled:
m_OverrideState: 1
m_Value: 1
Expand All @@ -143,6 +146,12 @@ MonoBehaviour:
hdr: 1
showAlpha: 0
showEyeDropper: 1
tint:
m_OverrideState: 0
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 1
showAlpha: 0
showEyeDropper: 1
maxFogDistance:
m_OverrideState: 1
m_Value: 500
Expand All @@ -166,24 +175,19 @@ MonoBehaviour:
maximumHeight:
m_OverrideState: 0
m_Value: 500
albedo:
m_OverrideState: 1
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
meanFreePath:
m_OverrideState: 1
m_Value: 50
min: 1
enableVolumetricFog:
m_OverrideState: 1
m_Value: 1
anisotropy:
albedo:
m_OverrideState: 1
m_Value: 0
min: -1
max: 1
m_Value: {r: 1, g: 1, b: 1, a: 1}
hdr: 0
showAlpha: 1
showEyeDropper: 1
globalLightProbeDimmer:
m_OverrideState: 1
m_Value: 1
Expand All @@ -193,11 +197,22 @@ MonoBehaviour:
m_OverrideState: 1
m_Value: 25
min: 0.1
denoisingMode:
m_OverrideState: 1
m_Value: 0
anisotropy:
m_OverrideState: 1
m_Value: 0
min: -1
max: 1
sliceDistributionUniformity:
m_OverrideState: 1
m_Value: 0.75
min: 0
max: 1
fogControlMode:
m_OverrideState: 1
m_Value: 1
screenResolutionPercentage:
m_OverrideState: 1
m_Value: 25
Expand All @@ -208,6 +223,19 @@ MonoBehaviour:
m_Value: 128
min: 1
max: 1024
volumetricFogBudget:
m_OverrideState: 0
m_Value: 0.25
min: 0
max: 1
resolutionDepthRatio:
m_OverrideState: 0
m_Value: 0.5
min: 0
max: 1
directionalLightsOnly:
m_OverrideState: 0
m_Value: 0
--- !u!114 &3474294613101294443
MonoBehaviour:
m_ObjectHideFlags: 3
Expand All @@ -226,6 +254,11 @@ MonoBehaviour:
m_OverrideState: 1
m_Value: 500
min: 0
directionalTransmissionMultiplier:
m_OverrideState: 0
m_Value: 1
min: 0
max: 1
cascadeShadowSplitCount:
m_OverrideState: 1
m_Value: 4
Expand Down
Loading