Skip to content

Fix HDRP Wizard windows not compatible with "preview" package version #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Fix HDRP Wizard windows not compatible with "preview" package version #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions com.unity.render-pipelines.high-definition/Editor/DefaultScene/HDWizard.Window.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,19 +544,22 @@ HelpBox CreateHdrpVersionChecker()
{
m_UsedPackageRetriever.ProcessAsync(k_HdrpPackageName, (installed, packageInfo) =>
{
// installed is not used because this one will be always installed
// With recent introduction of preview srp version, our HDRP wizard don't work with Version() call
// patch it for now until this is solve.
bool compatibleWithVersionCall = version.ToString().Contains("preview") ? false : true;

// installed is not used because this one will be always installed
if (packageInfo.source == PackageManager.PackageSource.Local)
{
helpBox.kind = HelpBox.Kind.Info;
helpBox.text = String.Format(Style.hdrpVersionWithLocalPackage, packageInfo.version, version);
}
else if(new Version(packageInfo.version) < new Version(version))
else if(compatibleWithVersionCall && (new Version(packageInfo.version) < new Version(version)))
{
helpBox.kind = HelpBox.Kind.Warning;
helpBox.text = String.Format(Style.hdrpVersionNotLast, packageInfo.version, version);
}
else if (new Version(packageInfo.version) == new Version(version))
else if (compatibleWithVersionCall && (new Version(packageInfo.version) == new Version(version)))
{
helpBox.kind = HelpBox.Kind.Info;
helpBox.text = String.Format(Style.hdrpVersionLast, version);
Expand Down