Fix issues with history sampling and hw dynamic res #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancescoC-unity
requested review from
sebastienlagarde,
JulienIgnace-Unity and
a team
|
It appears that you made a non-draft PR! |
TomasKiniulis
approved these changes
Sep 7, 2020
sebastienlagarde
approved these changes
Sep 8, 2020
|
@FrancescoC-unity does it need backport to 7 / 8 ? or it is only the new TAA? |
Already backported (you merged it friday) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues:
Taa was using the RTHandleScale for current history system, while it needed to use the RTHandleScale for previous history system.
Because the history system does not go through the HW dynamic system, therefore we should preserve the RTHandleScale computation.
Before fixing these issues the TAA will produce flickering halos around objects because history was sampled completely wrong.
With the fix
What have I tested: The repro case (note it mentions Gamecore, but it repros on dx12 too), both manual change of res and automatic script to change dyn res fraction.
Note: There is another hw dynamic res bug fixed by this PR #1652 , to workaround the issue you will see, after pressing play, change res -> see scene appearing small on corner -> force screen res to 100 -> remove force res and try again. This seems to work as a workaround. Otherwise just merge that branch into this.