Skip to content

Fix for non-static objects not being present at times in OnEnable probes #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Fix for non-static objects not being present at times in OnEnable probes #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de0288e
Fix
FrancescoC-unity Sep 3, 2020
5472ead
changelog
FrancescoC-unity Sep 3, 2020
b19fb98
Merge branch 'HDRP/staging' into HDRP/fix-issue-with-on-enable-probes…
sebastienlagarde Sep 24, 2020
5395c58
Merge branch 'HDRP/staging' into HDRP/fix-issue-with-on-enable-probes…
sebastienlagarde Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a migration issue with the rendering queue in ShaderGraph when upgrading to 10.x;
- Fixed null reference in the Undo callback of the graphics compositor
- Fixed cullmode for SceneSelectionPass.
- Fixed issue that caused non-static object to not render at times in OnEnable reflection probes.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down
4 changes: 4 additions & 0 deletions ...ipelines.high-definition/Runtime/Lighting/Reflection/HDAdditionalReflectionData.Legacy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ public override void PrepareCulling()
// Force the legacy system to not update the probe
cubeProbe.mode = ReflectionProbeMode.Custom;
cubeProbe.refreshMode = ReflectionProbeRefreshMode.ViaScripting;
#if UNITY_2020_2_OR_NEWER
if (m_ProbeSettings.mode == ProbeSettings.Mode.Realtime)
cubeProbe.renderDynamicObjects = true;
#endif
}
}
}