Skip to content

Fix for LookDev displaying probes as pink spheres #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Fix for LookDev displaying probes as pink spheres #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd43bf1
Don't toggle components if they are hidden in inspector or non editable
FrancescoC-unity Aug 5, 2020
adfb0a9
Changelog
FrancescoC-unity Aug 5, 2020
a109c29
Change flags to check
FrancescoC-unity Sep 9, 2020
33c0dbb
Merge branch 'HDRP/staging' into HDRP/fix-probe-appearing-in-look-dev
sebastienlagarde Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions com.unity.render-pipelines.core/Editor/LookDev/Stage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,16 +217,28 @@ void SetGameObjectVisible(bool visible)
if (go == null || go.Equals(null))
continue;
foreach (UnityEngine.Renderer renderer in go.GetComponentsInChildren<UnityEngine.Renderer>())
renderer.enabled = visible;
{
if((renderer.hideFlags & HideFlags.HideInInspector) == 0 && ((renderer.hideFlags & HideFlags.HideAndDontSave) == 0))
renderer.enabled = visible;
}
foreach (Light light in go.GetComponentsInChildren<Light>())
light.enabled = visible;
{
if ((light.hideFlags & HideFlags.HideInInspector) == 0 && ((light.hideFlags & HideFlags.HideAndDontSave) == 0))
light.enabled = visible;
}
}

// in case we add camera frontal light and such
foreach (UnityEngine.Renderer renderer in m_Camera.GetComponentsInChildren<UnityEngine.Renderer>())
renderer.enabled = visible;
{
if ((renderer.hideFlags & HideFlags.HideInInspector) == 0 && ((renderer.hideFlags & HideFlags.HideAndDontSave) == 0))
renderer.enabled = visible;
}
foreach (Light light in m_Camera.GetComponentsInChildren<Light>())
light.enabled = visible;
{
if ((light.hideFlags & HideFlags.HideInInspector) == 0 && ((light.hideFlags & HideFlags.HideAndDontSave) == 0))
light.enabled = visible;
}
}

public void OnBeginRendering(IDataProvider dataProvider)
Expand Down
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed RTGI in performance mode when light layers are enabled on the asset.
- Fixed SSS materials appearing black in matcap mode.
- Fixed a collision in the interaction of RTR and RTGI.
- Fix for lookdev toggling renderers that are set to non editable or are hidden in the inspector.

### Changed
- Preparation pass for RTSSShadows to be supported by render graph.
Expand Down