Skip to content

Fix XR Display providers not getting zNear and zFar updated on them. #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Fix XR Display providers not getting zNear and zFar updated on them. #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab4bbe5
Set XR Display near and far plane from the camera.
robinb-u3d Jul 14, 2020
cabfcbe
Updated changelog for XR Display near and far plane from camera.
robinb-u3d Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed path-traced subsurface scattering mixing with diffuse and specular BRDFs (1250601).
- Fixed custom pass re-ordering issues.
- Improved robustness of normal mapping when scale is 0, and mapping is extreme (normals in or below the tangent plane).
- Fixed XR Display providers not getting zNear and zFar plane distances passed to them when in HDRP.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
6 changes: 6 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/XR/XRSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ internal int GetMaxViews()
// Disable vsync on the main display when rendering to a XR device
QualitySettings.vSyncCount = 0;

if(display != null)
{
display.zNear = camera.nearClipPlane;
display.zFar = camera.farClipPlane;
}

CreateLayoutFromXrSdk(camera, singlePassAllowed);
}
else
Expand Down