Allow ShaderGraph generation to generate multiple render state [Skip CI] #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented Probe Volume light list build. * Implement transparency overdraw. * Implement XR occlusion mesh * Fix when no movecs are available. * Remove unnecessary workaround. * Fixed AO texture binding and usage. * Implement transparent SSR and fixed transparent depth prepass * Fixed a leak with the resource purge system. Fixed a gcalloc Properly bind normal and movec textures to SSR. * Temporary fix to a texture binding error with deferred compute shaders. * Fixed null ref * Fixed area shadows * Enabled test 2501 LightLayers * Enabled SSAO tests 2601/2602 * Fixed debug mode background color Re-enabled test 3002 DebugLightLayers * Fixed GCAlloc in PushFullScreenDebug Re-enabled test 4013 TransparentMotionVector * Fixed GCAlloc in Resolve MSAA functions Re-enabled test 5009 HDRISkyFlow * Reenabled 8106 * Fixed MSAA prepass and camera motion vector Re-enabled tests 9401 * Re-enabled tests 9402 * Re-enabled 9500, 9603 and 9604 * Fixed object motion vector pass with MSAA. Re-enabled tests 9601 and 9602 * Fixed AOV output Re-enabled test 9901 * Fixed binding of depth texture to volumetric lighting shader. * Custom Passes implementation WIP * Remove comment * Re-enabled tests 9700 9701 for custom passes. * Add comment. * typo * Fixed a null ref and binding of color pyramid. * Implemented MSAA resolve for custom pass.
sebastienlagarde
approved these changes
Jun 29, 2020
…#976) * Added an example CloudLayer render texture + rotation for cloud layer * Fix shader warnings * Better Inspector. Hacky fix for PBR sky * Add name of default tetxure in doc * Section for duplicating asset * Improve doc
* Fix test scene description asset UI * Added doc
…on in ray tracing effects (1258547). (#1042) * Added an option to extend the camera culling for skinned mesh animation in ray tracing effects (1258547). * Improved tooltip Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Change transparent SSR display name * changelog * Add frame settings docs update
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…re (#1061) * Added missing tooltips in the physical camera UI * Fix tooltips for DoF * Revert doc change * Custom drawing for the aperture * Code cleanup * Add missing comment * Changelog * Clamp the aperture to the correct range, avoid using hard-coded constants * Fixed more tooltips + typo
* Add guards to shadow includes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
alindmanUnity
approved these changes
Jul 1, 2020
* Force scene repaint on change of overridden exposure * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…e (1259930). (#1070) Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed the non-editable transparent writes motion vector and back then front rendering * Fixed alpha to mask reset in the material UI * Updated changelog * Fixed show after post process being visible in Lit SG material UI * Fixed displacement mode not showing in the material UI * Bump material version on HDRPProjectSettings * Moved depth offset keyword to base unlit * Fixed material multi-selection at several places * Moved common.hlsl and shaderpass.cs.hlsl before define block in shadergraph * Fixed depth offset displayed in material but disabled in SG * update HDRP test material * update DXR material * Update 709_CameraExtendedCulling.png Co-authored-by: Antoine Lelièvre <antoinel@unity3d.com>
* Fixed an issue where opening the look dev window with the light theme would make the window blink and eventually crash unity. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Allow to generate multiple render state of the same type, needed for some use cases like HDRP unlit shader:
Testing status
HDRP_Tests project is green locally. I tested the generation of the HDRP Unlit shader and it is now correct.
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffix%252Fmultiple-renderstate/.yamato%252F_abv.yml%2523all_project_ci_fast-trunk/2662083/job/pipeline