Porting most of post processing to Render graph #1038
Conversation
# Conflicts: # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs
| // Note: some platforms can't clear a partial render target so we directly draw black triangles | ||
| using (var builder = renderGraph.AddRenderPass<GuardBandPassData>("Guard Band Clear", out var passData, ProfilingSampler.Get(HDProfileId.GuardBandClear))) | ||
| { | ||
| passData.source = builder.ReadTexture(source); |
There was a problem hiding this comment.
Shouldn't this be WriteTexture?
There was a problem hiding this comment.
Yup, my mistake (my brain saw source and put read :D )
| if (m_PostProcessEnabled) | ||
| { | ||
| // // Temporal anti-aliasing goes first | ||
| // bool taaEnabled = false; | ||
| // Guard bands (also known as "horrible hack") to avoid bleeding previous RTHandle |
There was a problem hiding this comment.
Comment is duplicated in the static function
| { | ||
| passData.source = builder.ReadTexture(source); | ||
| passData.parameters = PrepareExposureParameters(hdCamera); | ||
| passData.prevExposure = prevExposureHandle; |
There was a problem hiding this comment.
An explicit Write/Read should still be done here.
The reason is that the pass needs to know that it writes to an imported texture so that it's considered as side effect and cannot be pruned.
|
|
||
| if (m_Exposure.mode.value == ExposureMode.AutomaticHistogram) | ||
| { | ||
| passData.exposureDebugData = renderGraph.ImportTexture(m_DebugExposureData); |
| passData.parameters = PrepareApplyExposureParameters(hdCamera); | ||
| RTHandle prevExp; | ||
| GrabExposureHistoryTextures(hdCamera, out prevExp, out _); | ||
| passData.prevExposure = renderGraph.ImportTexture(prevExp); |
There was a problem hiding this comment.
Same here: Read/Write required.
| GrabExposureHistoryTextures(hdCamera, out prevExp, out _); | ||
| passData.prevExposure = renderGraph.ImportTexture(prevExp); | ||
|
|
||
| TextureHandle dest = renderGraph.CreateTexture(new TextureDesc(Vector2.one, true, true) |
There was a problem hiding this comment.
This is repeated in several places. We could probably do a helper function to reduce code footprint
| passData.depthBuffer = builder.ReadTexture(depthBuffer); | ||
| passData.motionVecTexture = builder.ReadTexture(motionVectors); | ||
| passData.depthMipChain = builder.ReadTexture(depthBufferMipChain); | ||
| passData.prevHistory = renderGraph.ImportTexture(prevHistory); |
| { | ||
| var cs = exposureParameters.exposureCS; | ||
| int kernel; | ||
|
|
||
| var sourceTex = colorBuffer; | ||
|
|
||
| // NOTE: Breakpoint here. |
| @@ -60,7 +60,9 @@ class AfterPostProcessPassData | |||
| parameters.blueNoise, | |||
| inputColor, | |||
| afterPostProcessBuffer, | |||
| depthBuffer, | |||
| prepassOutput.depthBuffer, | |||
There was a problem hiding this comment.
Was this tested with MSAA?
I think we need prepassOutput.resolvedDepthBuffer here
| @@ -217,7 +217,7 @@ class TempPassData { }; | |||
|
|
|||
| aovRequest.PushCameraTexture(m_RenderGraph, AOVBuffers.Color, hdCamera, colorBuffer, aovBuffers); | |||
|
|
|||
| TextureHandle postProcessDest = RenderPostProcess(m_RenderGraph, colorBuffer, prepassOutput.resolvedDepthBuffer, backBuffer, cullingResults, hdCamera); | |||
| TextureHandle postProcessDest = RenderPostProcess(m_RenderGraph, prepassOutput, colorBuffer, backBuffer, cullingResults, hdCamera); | |||
There was a problem hiding this comment.
See comment above, this will cause a regression.
|
Addressed stuff from this review, will split into smaller functions when I am done with the dof conversion (another PR) |
Wowee that's a big one, ported most post processing stuff to render graph.
Still missing DoF (changed from when I started)
And custom PP.
Yamato: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/HDRP%252Fport-pp-to-rendergraph/.yamato%252Fall-hdrp_dxr.yml%2523All_HDRP_DXR_CUSTOM-REVISION/2638716/job