[On Hold, Needs SRP Landing] Shader Stripping #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzhang-unity
approved these changes
Feb 15, 2022
etienne-p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a property to the Universal Render Pipeline asset to allow for Screen Coord Override shader stripping.
So we add a shader preprocessor making sure the property is set to true as it is needed for CD.
Note: I have a follow up PR to Graphics Unity-Technologies/Graphics#7121 moving shader stripping to URP global settings. This PR already matches this change so we'll wait for the follow up PR to land before landing this.