Fix bug with namespace when logs command run before start #5789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perhaps worth noting: this fix works by deleting code. That's only possible because of the specifics of the change in #5660, i.e. my last pm2 contribution. I opted to split them up, and this second half took me honestly too long to create. |
|
@Unitech any update on how mergeable this is? Happy to address any feedback you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the ticket linked above, and this is my attempt at a fix.
This implementation is something my company has been using (via
pnpm patch) for a few months now to good effect. Others might benefit from it too.I tried to do something similar to what I did in my past PR (#5660), since that one seemed rather painless.