Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chalk from 3.0.0 to 4.1.2 #5489

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

khrj
Copy link

@khrj khrj commented Nov 24, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

This PR updates chalk from 3.0.0 to 4.1.2. Chalk 3.0.0 uses the deprecated __proto__ API, which is also a security vulnerability. While the way its used in chalk does not create a security issue, some runtimes, such as Deno, do not implement it, which creates errors. This also creates problems when using the --disable-proto flag with node.

Chalk v4 has the following breaking changes:

  • It requires a minimum node version of 10. pm2 already mandates a node version of 12 or higher
  • It changes the Level typescript enum, which pm2 does not happen to use

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2022

CLA assistant check
All committers have signed the CLA.

@pubmikeb
Copy link

pubmikeb commented Dec 6, 2022

But why do you bump chalk to 4.1.2 (July, 30 2021) and not to 5.1.2 (October, 12 2022)?

@khrj
Copy link
Author

khrj commented Dec 7, 2022

Chalk V5 requires ESM -- I'm not too familiar with pm2's codebase, but from a glance it looks like it wouldn't work with it

@lino-levan
Copy link

@Unitech This is blocking adoption through Deno. What has to be done for this to be pushed forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants