Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given --uid add all its gids automatically #3204

Merged
merged 4 commits into from
Oct 10, 2017
Merged

Conversation

jmeit
Copy link
Contributor

@jmeit jmeit commented Oct 9, 2017

Please always submit pull requests on the development branch.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2957
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

Please update this template with something that matches your PR

jmeit added 3 commits October 5, 2017 18:33
Reversed the order of setting uid and gid. When uid is set first, the process doesn't have permission to set the gid. So they've been swapped.
When using the option `--uid <uid>` the process now runs with all of that user's permissions, including its groups.
Allow mixing of args uid and gid
@CLAassistant
Copy link

CLAassistant commented Oct 9, 2017

CLA assistant check
All committers have signed the CLA.

@Unitech Unitech changed the base branch from master to development October 10, 2017 09:41
@Unitech Unitech merged commit 4d5ca25 into Unitech:development Oct 10, 2017
inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
Given --uid add all its gids automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants