Skip to content

Use jacodb from GitHub Packages Registry #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Jul 31, 2025

This PR switches from using JitPack for jacodb artifacts to using GitHub Package Registry.

NOTE: Using GPR as a consumer (that is, download JARs from repository) requires an authorization via a GitHub token with packages: read permissions. The local setup is very simple:

@Lipen Lipen requested a review from Saloed July 31, 2025 13:59
Copy link
Collaborator

@Saloed Saloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review jvm test issues

@@ -14,6 +14,8 @@ repositories {
maven("https://jitpack.io")
}

setupJacodbGitHubPackagesRepository()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need jacodb repo in all projects?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need JitPack repo in all projects? Same thing. So it does not hurt us to add jacodb GPR in all sub-projects using the convention plugin.

We could also make the GPR setup a separate convention plugin (I have a working solution), but it looks more weird than this Project extension function.

@Lipen
Copy link
Member Author

Lipen commented Jul 31, 2025

Please, review jvm test issues

I can reproduce it locally. Also, if I build jacodb to the local maven repo using JDK 8, and then use those artifacts in USVM (running with jdk 11, since usvm requires it), tests pass. Thus, it is the issue related to the built artifacts. I already have heard the rumors that such situations might happen, and that "compiling with java 8 compatibility" is no the same as "compiling with JDK 8 directly", but never seen this in reality.

@Saloed What is the action here? Again just hide the problem by using jdk 8 for building jacodb on CI?

@Lipen
Copy link
Member Author

Lipen commented Jul 31, 2025

He-he, similar issue: javalin/javalin#2117

@Lipen
Copy link
Member Author

Lipen commented Jul 31, 2025

Using options.release = 8 in jacodb with jdk21 locally produces artifacts that pass USVM tests. So probably this is a solution on the jacodb side: UnitTestBot/jacodb#337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants