-
Notifications
You must be signed in to change notification settings - Fork 25
Use jacodb from GitHub Packages Registry #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, review jvm test issues
@@ -14,6 +14,8 @@ repositories { | |||
maven("https://jitpack.io") | |||
} | |||
|
|||
setupJacodbGitHubPackagesRepository() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need jacodb repo in all projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need JitPack repo in all projects? Same thing. So it does not hurt us to add jacodb GPR in all sub-projects using the convention plugin.
We could also make the GPR setup a separate convention plugin (I have a working solution), but it looks more weird than this Project
extension function.
I can reproduce it locally. Also, if I build jacodb to the local maven repo using JDK 8, and then use those artifacts in USVM (running with jdk 11, since usvm requires it), tests pass. Thus, it is the issue related to the built artifacts. I already have heard the rumors that such situations might happen, and that "compiling with java 8 compatibility" is no the same as "compiling with JDK 8 directly", but never seen this in reality. @Saloed What is the action here? Again just hide the problem by using jdk 8 for building jacodb on CI? |
He-he, similar issue: javalin/javalin#2117 |
Using |
This PR switches from using JitPack for jacodb artifacts to using GitHub Package Registry.
NOTE: Using GPR as a consumer (that is, download JARs from repository) requires an authorization via a GitHub token with
packages: read
permissions. The local setup is very simple:read:packages
" permissions.gpr.user
andgpr.key
Gradle properties globally in~/.gradle/gradle.properties
file. For example: