Skip to content

Remove duplicates in SARIF report #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,26 @@ object TestGenerator {
}
}

private fun mergeSarifReports(model: GenerateTestsModel, sarifReportsPath : Path) {
private fun mergeSarifReports(model: GenerateTestsModel, sarifReportsPath: Path) {
val mergedReportFile = sarifReportsPath
.resolve("${model.project.name}Report.sarif")
.toFile()
// deleting the old report so that `sarifReports` does not contain it
mergedReportFile.delete()

val sarifReports = sarifReportsPath.toFile()
.walkTopDown()
.filter { it.extension == "sarif" }
.map { it.readText() }
.toList()

val mergedReport = SarifReport.mergeReports(sarifReports)
val mergedReportPath = sarifReportsPath.resolve("${model.project.name}Report.sarif")
mergedReportPath.toFile().writeText(mergedReport)
mergedReportFile.writeText(mergedReport)

// notifying the user
SarifReportNotifier.notify(
info = """
SARIF report was saved to ${toHtmlLinkTag(mergedReportPath.toString())}$HTML_LINE_SEPARATOR
SARIF report was saved to ${toHtmlLinkTag(mergedReportFile.path)}$HTML_LINE_SEPARATOR
You can open it using the VS Code extension "Sarif Viewer"
""".trimIndent()
)
Expand Down