Skip to content

Correctly handle patch versions containing dots #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Fixes #2599 by handling non-numeric version postfixes separated by dot (e.g. 5.2.25.RELEASE, which contains 4 dots and was previously failing versionComponents.size <= 3 check).

How to test

Manual tests

Error from issue #2599 should no longer reproduce.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug comp-spring Issue is related to Spring projects support labels Sep 15, 2023
@IlyaMuravjov IlyaMuravjov merged commit f364483 into main Sep 15, 2023
@IlyaMuravjov IlyaMuravjov deleted the ilya_m/fix_patch_with_dot branch September 15, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Spring framework failure
2 participants