Refactor to reduce coupling of base UtBot implementation with Spring-specific features - #2411
Merged
Merged
Conversation
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
July 17, 2023 10:11
a7aaf80 to
6569628
Compare
ApplicationContext into multiple interfaces
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
2 times, most recently
from
July 18, 2023 12:50
19cb36d to
2874151
Compare
Closed
6 tasks
IlyaMuravjov
marked this pull request as ready for review
July 18, 2023 15:25
sergeypospelov
requested changes
Jul 19, 2023
| } | ||
| } | ||
|
|
||
| class SimpleUtExecutionInstrumentation( |
Member
There was a problem hiding this comment.
Let's extract it to a separate file
| classfileBuffer: ByteArray | ||
| ) = null | ||
|
|
||
| class Factory : Instrumentation.Factory<Result<*>, InvokeInstrumentation> { |
| } | ||
| } | ||
|
|
||
| class Factory : Instrumentation.Factory<Trace, ExecutionTraceInstrumentation> { |
| return instrumenter.classByteCode | ||
| } | ||
|
|
||
| class Factory : Instrumentation.Factory<Result<*>, CoverageInstrumentation> { |
| } | ||
| } | ||
|
|
||
| class Factory : Instrumentation.Factory<Result<*>, InvokeWithStaticsInstrumentation> { |
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
July 19, 2023 14:53
396a4fb to
186a0fb
Compare
EgorkaKulikov
approved these changes
Jul 20, 2023
…NullPointerException` into one method
…lementors` with `beanDefinitions.isNotEmpty()`
…pplicationContext` type
…arams in functions and constructors
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
July 20, 2023 08:59
f9a6a20 to
dbf4da7
Compare
sergeypospelov
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2358, #2226
How to test
Regression tests (this pull request should not change UtBot semantics at all)
Self-check list