Add specific annotations for Spring integration testing#2281
Merged
Conversation
EgorkaKulikov
added
ctg-enhancement
EgorkaKulikov
force-pushed
the
egor/cg_annotations_for_integration_tests
branch
from
5a2eae1 to
b35a614
Compare
Collaborator
IlyaMuravjov
left a comment
IlyaMuravjov
left a comment
There was a problem hiding this comment.
It's also desirable to add @Transactional and @AutoConfigureTestDatabase if they are present on the test module class path.
EgorkaKulikov
force-pushed
the
egor/cg_annotations_for_integration_tests
branch
from
a101ee3 to
de7c03f
Compare
EgorkaKulikov
force-pushed
the
egor/cg_annotations_for_integration_tests
branch
from
de7c03f to
dadf0bf
Compare
sofurihafe
reviewed
Jun 28, 2023
sofurihafe
reviewed
Jun 28, 2023
sofurihafe
reviewed
Jun 28, 2023
Damtev
requested changes
Jun 28, 2023
|
|
||
| // Annotations | ||
|
|
||
| enum class AnnotationTarget { |
Member
There was a problem hiding this comment.
May we use kotlin.annotation.AnnotationTarget instead of creating our own type?
Collaborator
Author
There was a problem hiding this comment.
Bue... it may lead the user to a wrong concern that we support or going to support all items from it. Next, in current implementation we are able to do smth like Class(classId) to specify the scope of current or outer class, for example. After that, do not forget that we get salary for the changed lines...
|
|
||
| /** | ||
| * NOTE: use `StatementConstructor.addAnnotation` | ||
| * instead of explicit constructor call. |
Member
There was a problem hiding this comment.
I guess, it's more preferrable to replace all these warnings with TODOs for rearranging packages/classes
Collaborator
Author
There was a problem hiding this comment.
I'm not sure it will be ever done in current codegen. We know about packaging in general. I added this warnings just for other users to avoid additional mess in the code.
Member
There was a problem hiding this comment.
I'm not sure it will be ever done in current codegen
Perhaps it will not, but IMHO todo is much more notable than such a simple comment.
| } | ||
|
|
||
| override fun createDataProviderAnnotations(dataProviderMethodName: String) = mutableListOf<CgAnnotation>() | ||
| override fun addDataProviderAnnotations(dataProviderMethodName: String) { } |
Collaborator
Author
There was a problem hiding this comment.
There is not an error, just annotation is not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2317
How to test
Should be tested as a part of full integration testing checks.
Self-check list