Skip to content

Use one and modern Mockito version in whole project #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

Use one and modern Mockito version in whole project #2271

merged 1 commit into from
Jun 9, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Version of Mockito, specified in properties file, was very old - upgraded it.
Some different versions were used in modules - unified it.

How to test

Automated tests

utbot-samples pipeline as a set of regression checks

Manual tests

Basic regression of mocks

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-settings Issue is related to settings labels Jun 9, 2023
@EgorkaKulikov EgorkaKulikov requested a review from Damtev June 9, 2023 08:26
Damtev
Damtev approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) June 9, 2023 08:42
@EgorkaKulikov EgorkaKulikov merged commit e6c479a into main Jun 9, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/upgrade_mockito_version branch June 9, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damtev Damtev Damtev approved these changes

Assignees
No one assigned
Labels
comp-settings Issue is related to settings ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorkaKulikov @Damtev