Skip to content

Conversation

@sofurihafe
Copy link
Member

@sofurihafe sofurihafe commented May 10, 2023

Description

This PR introduces extended version of UtModel, UtModelWrapper. For code-generation purposes we pack UtModels with test set ids and execution ids. It was made primarily for shared among all test methods global variables (i.e. class fields).

Fixes #2104, #2107, #2196

How to test

Automated tests

Run utbot-samples.

Manual tests

Open pet-clinic project and generate tests for OwnerController and VetController. There must be no unused global variables, recreated global variables.

Open non-spring project and generate some tests. There everything must be as usual.

@sofurihafe sofurihafe force-pushed the andrey-t/improved_getorcreatevariable branch from 6d12b80 to 8846ff9 Compare May 11, 2023 20:23
@sofurihafe sofurihafe added comp-spring Issue is related to Spring projects support comp-codegen Issue is related to code generator labels May 11, 2023
@sofurihafe sofurihafe force-pushed the andrey-t/improved_getorcreatevariable branch from 8846ff9 to a6a3e72 Compare May 11, 2023 20:28
@sofurihafe sofurihafe marked this pull request as ready for review May 11, 2023 20:28
@sofurihafe sofurihafe changed the title [draft] Improved get-or-create-variable logic Improved get-or-create-variable logic May 11, 2023
@sofurihafe sofurihafe requested a review from EgorkaKulikov May 11, 2023 23:34
@sofurihafe sofurihafe force-pushed the andrey-t/improved_getorcreatevariable branch 2 times, most recently from 1644040 to 6bcc296 Compare May 15, 2023 13:47
@sofurihafe sofurihafe requested a review from Damtev May 15, 2023 13:49
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, LGTM

@sofurihafe sofurihafe force-pushed the andrey-t/improved_getorcreatevariable branch from 6bcc296 to f91e900 Compare May 15, 2023 13:51
@EgorkaKulikov EgorkaKulikov merged commit c78fa93 into main May 15, 2023
@EgorkaKulikov EgorkaKulikov deleted the andrey-t/improved_getorcreatevariable branch May 15, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support

Projects

None yet

4 participants