Skip to content

Automatically install Spring test dependencies into user project if required #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

Automatically install Spring test dependencies into user project if required #2197

merged 1 commit into from
May 15, 2023

Conversation

@EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented May 9, 2023 •
edited
Loading

Description

Supported an auto-installation of Spring or Spring Boot testing dependencies into user projects

Also:

  • Added a setting to choose unit or integration testing
  • "Framework will be installed" message is shown
  • This setting is stored in State
  • LibraryMatcher class refactored

How to test

Manual tests

  • Pure Spring project, no test dependency => it is installed with the same version as in project
  • Pure Spring project, test dependency is present => no more dependencies installed
  • Same two scenarios for Spring Boot projects

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-ui Improvements of plugin UI appearence and functionality comp-spring Issue is related to Spring projects support labels May 9, 2023
@EgorkaKulikov EgorkaKulikov requested a review from IlyaMuravjov May 9, 2023 18:28
IlyaMuravjov
IlyaMuravjov requested changes May 9, 2023
View reviewed changes
@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_test_dependencies branch from 644bdd6 to 812342d Compare May 12, 2023 15:16
@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_test_dependencies branch from 812342d to 7ce7f6f Compare May 12, 2023 15:17
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) May 12, 2023 16:08
@EgorkaKulikov EgorkaKulikov merged commit b8fc39e into main May 15, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/spring_test_dependencies branch May 15, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IlyaMuravjov IlyaMuravjov IlyaMuravjov approved these changes

Assignees

No one assigned

Labels

comp-spring Issue is related to Spring projects support comp-ui Improvements of plugin UI appearence and functionality ctg-enhancement New feature, improvement or change request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EgorkaKulikov @IlyaMuravjov